Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse settings array instead of compiling them #449

Merged
merged 1 commit into from
Aug 1, 2016

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Jul 31, 2016

No description provided.

@commy2 commy2 added this to the 3.0.1 milestone Jul 31, 2016
@commy2 commy2 removed the WIP label Jul 31, 2016
@@ -28,6 +28,30 @@ Author:
#define ASCII_ARRAY_OPEN (toArray "[" select 0)
#define ASCII_ARRAY_CLOSE (toArray "]" select 0)

private _fnc_parseArray = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function takes a string as input, so _fnc_parseString?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a stringified array. "[<...>]". parseNumber for example also takes and not

parseNumber "1"
-> 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

@Killswitch00 Killswitch00 merged commit 24e49c0 into master Aug 1, 2016
@commy2 commy2 deleted the settings-parse-array-method branch August 1, 2016 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants